Difference between revisions of "Testing"

From Medusa: Coordinate Free Mehless Method implementation
Jump to: navigation, search
(Fixing bugs)
 
(21 intermediate revisions by 3 users not shown)
Line 1: Line 1:
 +
{{Info|This page is meant for Medusa developers.}}
 +
 
<figure id="fig:tests">
 
<figure id="fig:tests">
[[File:tests.png|500px|thumb|upright=2|alt=Output of successfull ./run_tests.sh script run.|<caption>Output of successfull <code>./run_tests.sh</code> script run.</caption>]]
+
[[File:tests.png|500px|thumb|upright=2|alt=Output of a successfull ./run_tests.py script run.|<caption>Output of successfull <code>./run_tests.py</code> script run.</caption>]]
 
</figure>
 
</figure>
  
Line 6: Line 8:
 
* unit tests
 
* unit tests
 
* style checks
 
* style checks
* docs check
+
* documentation checks
* system configuration check
+
* examples
 +
 
 +
The <code>./run_tests.py</code> script controlls all tests
 +
<syntaxhighlight lang="bash">
 +
usage: run_tests.py [-h] [-c] [-b] [-t] [--build-examples] [-e] [-s] [-d]
 +
 
 +
Script to check you medusa library.
  
The <code>./run_tests.sh</code> script controlls all tests
+
optional arguments:
<syntaxhighlight lang="bash" line>
+
  -h, --help          show this help message and exit
Usage: ./run_tests.sh
+
   -c, --configure    check your system configuration
Options:
+
   -b, --build        build the library
   -c  run only configuration test
+
   -t, --tests        run all tests
   -t   run only unit tests
+
   --build-examples    build all examples
   -s   run only stylechecks
+
   -e, --run-examples  run selected examples
   -d  run only docs check
+
   -s, --style        style checks all sources and reports any errors
   -h  print this help
+
   -d, --docs          generate and check for documentation errors
Example:
 
./run_tests.sh -sd
 
 
</syntaxhighlight>
 
</syntaxhighlight>
  
Before pushing run <syntaxhighlight lang="bash" inline>./run_tests.sh</syntaxhighlight>.
+
Before pushing, always run <syntaxhighlight lang="bash" inline>./run_tests.py</syntaxhighlight>.
This script makes and executes all <syntaxhighlight lang="bash" inline> <util_name>_test.cpp </syntaxhighlight> test files, checks coding style and
+
This script compiles and executes all tests, checks coding style, documentation and examples.
documentation. If anything is wrong you will get pretty little red error, but if you see green, like in <xr id="fig:tests"/>, you're good to go.
+
If anything is wrong you will get pretty little red error, but if you see green, like in <xr id="fig:tests"/>, you're good to go.
  
 
=Unit tests=
 
=Unit tests=
Line 45: Line 51:
  
 
The basic structure is  
 
The basic structure is  
<syntaxhighlight lang="c++" line>
+
<syntaxhighlight lang="c++">
 
TEST(Group, Name) {
 
TEST(Group, Name) {
 
     EXPECT_EQ(a, b);
 
     EXPECT_EQ(a, b);
Line 53: Line 59:
 
Each header file should be accompanied by a <syntaxhighlight lang="bash" inline><util_name>_test.cpp</syntaxhighlight> with unit tests.
 
Each header file should be accompanied by a <syntaxhighlight lang="bash" inline><util_name>_test.cpp</syntaxhighlight> with unit tests.
  
'''
+
<b>When writing unit tests, always write them thoroughly and slowly, take your time.
When writing unit tests, always write them thoroughly and slowly, take your time.
+
Never copy your own code's output to the test; rather produce it by hand or with another trusted tool.
Never copy your own code's ouput to the test; rather produce it by hand or with another trusted tool.
 
 
Even if it seems obvious the code is correct, remember that you are writing tests also for the future.
 
Even if it seems obvious the code is correct, remember that you are writing tests also for the future.
If tests have a bug, it is much harder to debug!
+
If tests have a bug, it is much harder to debug!</b>
'''
+
 
 +
See our examples in [http://e6.ijs.si/medusa/docs/html/examples.html technical documentation].
  
 
==Running unit tests==
 
==Running unit tests==
  
Tests can be run all at once via <syntaxhighlight lang="bash" inline>make run_all_tests</syntaxhighlight> or individually via eg. <syntaxhighlight lang="bash" inline>make basisfunc_run_tests </syntaxhighlight>.
+
Tests can be run all at once via <syntaxhighlight lang="bash" inline>make medusa_run_tests</syntaxhighlight> or individually via eg. <syntaxhighlight lang="bash" inline>make operators_run_tests </syntaxhighlight>.
  
Compiled binary supports running only specified test. Use <syntaxhighlight lang="bash" inline> ./all_tests --gtest_filter=Domain*</syntaxhighlight> for filtering and <syntaxhighlight lang="bash" inline> ./all_tests --help </syntaxhighlight> for more options.
+
Compiled binary supports running only specified test. Use <syntaxhighlight lang="bash" inline>./bin/medusa_tests --gtest_filter=Domain*</syntaxhighlight> or
 +
simply <code>GF="Domain" make domain_run_tests</code> for filtering and <syntaxhighlight lang="bash" inline>./bin/medusa_tests --help </syntaxhighlight> for more options.
  
 
==Fixing bugs==
 
==Fixing bugs==
Line 70: Line 77:
  
 
= Style check =
 
= Style check =
Before commiting, a linter <code>cpplint.py</code> is ran on all the source and test files to make sure that the code follows the [[coding style|style guide]].
+
Before committing, a linter <code>cpplint.py</code> is ran on all the source and test files to make sure that the code follows the [[coding style|style guide]].
 
The linter is not perfect, so if any errors are unjust, feel free to comment appropriate lines in the linter out and commit the change.
 
The linter is not perfect, so if any errors are unjust, feel free to comment appropriate lines in the linter out and commit the change.
  
 
= Docs check =
 
= Docs check =
Every function, class or method should also have documentation as einforced by doxygen in the header where they are defined.
+
Every function, class or method should also have documentation as enforced by doxygen in the header where they are defined.
In the comment block, all parameters, and return value should be meaningully described. It can also containg a short example.
+
In the comment block, all parameters, and return value should be meaningfully described. It can also containing a short example.
  
 
Example:
 
Example:
<syntaxhighlight lang="c++" line>
+
<syntaxhighlight lang="c++">
 
/**
 
/**
 
  * Computes the force that point a inflicts on point b.
 
  * Computes the force that point a inflicts on point b.
Line 89: Line 96:
 
</syntaxhighlight>
 
</syntaxhighlight>
  
Any longer discussions about the method used or long examples belog to this wiki, but can be linked from the docs.
+
Any longer discussions about the method used or long examples belong to this wiki, but can be linked from the docs.
 
 
  
= Configuration testing =
+
= Continuous build =
 +
We use GitLab Runner, an open source project that is used to run your jobs and send the results back to GitLab. It is used in conjunction with GitLab CI, the open-source continuous integration service included with GitLab that coordinates the jobs.
  
The script [https://gitlab.com/e62Lab/e62numcodes/blob/master/scripts/configure.sh scripts/configure.sh] checks
+
[https://docs.gitlab.com/runner/#features Runner features]
the computer has appropriate packages and that very basic code examples (hdf5, sfml) compile.
 
It currently support arch like and ubuntu like distros.
 
  
If you find yourself making modification to [https://gitlab.com/e62Lab/e62numcodes/blob/master/.gitlab-ci.yml .gitlab-ci.yml] then maybe you should
+
To configure runner that perform MM test on each commit edit <code>.gitlab-ci.yml</code> in repository.
update this check as well, as well as some documentation in the [[how to build]] page but this should not happen very often.
 

Latest revision as of 14:35, 17 January 2019

Info: This page is meant for Medusa developers.

Output of a successfull ./run_tests.py script run.
Figure 1: Output of successfull ./run_tests.py script run.

We have 4 different kind of tests in this library:

  • unit tests
  • style checks
  • documentation checks
  • examples

The ./run_tests.py script controlls all tests

usage: run_tests.py [-h] [-c] [-b] [-t] [--build-examples] [-e] [-s] [-d]

Script to check you medusa library.

optional arguments:
  -h, --help          show this help message and exit
  -c, --configure     check your system configuration
  -b, --build         build the library
  -t, --tests         run all tests
  --build-examples    build all examples
  -e, --run-examples  run selected examples
  -s, --style         style checks all sources and reports any errors
  -d, --docs          generate and check for documentation errors

Before pushing, always run ./run_tests.py. This script compiles and executes all tests, checks coding style, documentation and examples. If anything is wrong you will get pretty little red error, but if you see green, like in Figure 1, you're good to go.

Unit tests

All library code is tested by means of unit tests. Unit tests provide verification, are good examples and prevent regressions. For any newly added functionality, a unit test testing that functionality must be added.

Writing unit tests

Every new functionality (eg. added class, function or method) should have a unit test. Unit tests

  • assure that code compiles
  • assure that code executes without crashes
  • assure that code produces expected results
  • define observable behaviour of the method, class, ...
  • prevent future modifications of this code to change this behaviour accidentally

Unit tests should tests observable behaviour, eg. if function gets 1 and 3 as input, output should be 6. They should test for edge cases and most common cases, as well as for expected death cases.

We are using Google Test framework for our unit tests. See their introduction to unit testing for more details.

The basic structure is

TEST(Group, Name) {
    EXPECT_EQ(a, b);
}

Each header file should be accompanied by a <util_name>_test.cpp with unit tests.

When writing unit tests, always write them thoroughly and slowly, take your time. Never copy your own code's output to the test; rather produce it by hand or with another trusted tool. Even if it seems obvious the code is correct, remember that you are writing tests also for the future. If tests have a bug, it is much harder to debug!

See our examples in technical documentation.

Running unit tests

Tests can be run all at once via make medusa_run_tests or individually via eg. make operators_run_tests.

Compiled binary supports running only specified test. Use ./bin/medusa_tests --gtest_filter=Domain* or simply GF="Domain" make domain_run_tests for filtering and ./bin/medusa_tests --help for more options.

Fixing bugs

When you find a bug in the normal code, fix it and write a test for it. The test should fail before the fix, and pass after the it.

Style check

Before committing, a linter cpplint.py is ran on all the source and test files to make sure that the code follows the style guide. The linter is not perfect, so if any errors are unjust, feel free to comment appropriate lines in the linter out and commit the change.

Docs check

Every function, class or method should also have documentation as enforced by doxygen in the header where they are defined. In the comment block, all parameters, and return value should be meaningfully described. It can also containing a short example.

Example:

/**
 * Computes the force that point a inflicts on point b.
 *
 * @param a The index of the first point.
 * @param b The index of the second point
 * @return The size of the force vector from a to b.
 */
double f (int a, int b);

Any longer discussions about the method used or long examples belong to this wiki, but can be linked from the docs.

Continuous build

We use GitLab Runner, an open source project that is used to run your jobs and send the results back to GitLab. It is used in conjunction with GitLab CI, the open-source continuous integration service included with GitLab that coordinates the jobs.

Runner features

To configure runner that perform MM test on each commit edit .gitlab-ci.yml in repository.